Fix ResourceWarning: unclosed database in SqliteReader and unit tests#210
Merged
Fix ResourceWarning: unclosed database in SqliteReader and unit tests#210
Conversation
- SqliteReader was missing a close() method - sqlite3.Connection as a context manager does NOT close the connection it only commits or rolls back the transaction.
yunzheng
force-pushed
the
fix-sqlite3-resourcewarning
branch
from
3d286ac to
1650e5c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #210 +/- ##
==========================================
+ Coverage 83.33% 83.35% +0.01%
==========================================
Files 35 35
Lines 3714 3718 +4
==========================================
+ Hits 3095 3099 +4
Misses 619 619
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This pull request fixes ResourceWarning about unclosed database connections in Python 3.13+ by implementing proper resource cleanup for SQLite connections.
Changes:
- Added a close() method to SqliteReader to properly close database connections
- Updated test cases to use closing() context manager for explicit connection cleanup
- Added explicit commit() calls in tests where data persistence is required
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| flow/record/adapter/sqlite.py | Implements close() method in SqliteReader to properly close database connections |
| tests/adapter/test_sqlite_duckdb.py | Updates all test cases to use closing() wrapper and adds explicit commit() calls for proper transaction handling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Schamper
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #209